FreeSWITCH

Don't load event socket on bind error

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.2.9
  • Component/s: mod_event_socket
  • Labels:
    None
  • Environment:
    Mac
  • Platform:
    Linux x86/gcc
  • FreeSWITCH GIT Revision:
     Sat Aug 21 22:39:01 2010 -0500
  • Reproduced with GIT HEAD?:
    N/A
  • lsb_release:
    N/A
  • Target Version:

Description

mod event socket retries endlessly on bind (say 8021) error. It makes sense on a server, but for FS runs on a desktop, i.e. fscomm, it's better to just fail load the mod.

This patch added a new config param: stop-on-bind-error.

It actually has a problem. it returns SWITCH_STATUS_TERM on fail. It just stops the run time loop, but the mod still marked as loded - I can see this when I try to load the mod again.

Please review the code, and if there's a way to "fail" the load completely, I can update the patch.

Thanks.
  1. File
    es_stop_on_bind_error.diff
    27/Aug/10 7:22 AM
    2 kB
    Seven Du
  2. File
    mod_event_socket_abort_on_fail_bind.diff
    15/Dec/11 7:38 PM
    5 kB
    Marc Olivier Chouinard

Activity

Ascending order - Click to sort in descending order
Mike Jerris made changes -
Field Original Value New Value
Workflow jira [ 13111 ] Freeswitch [ 14640 ]
Mike Jerris made changes -
Component/s mod_event_socket [ 10072 ]
Mike Jerris made changes -
Key MODEVENT-69 FS-1307
Component/s mod_event_socket [ 10282 ]
Component/s mod_event_socket [ 10072 ]
Project Event handler modules [ 10050 ] FreeSWITCH [ 10141 ]
Hide
Permalink
Marc Olivier Chouinard added a comment -
I've uploaded a new patch. This basicly wont load the module if the socket can't be binded. It also allow you to use the critical="true" in the modules list so FS fail to load compleatly also.

This is untested !

Comments ?
Show
Marc Olivier Chouinard added a comment - I've uploaded a new patch. This basicly wont load the module if the socket can't be binded. It also allow you to use the critical="true" in the modules list so FS fail to load compleatly also. This is untested ! Comments ?
Marc Olivier Chouinard made changes -
Attachment mod_event_socket_abort_on_fail_bind.diff [ 15341 ]
Marc Olivier Chouinard made changes -
Assignee Mike Jerris [ mikej ] Marc Olivier Chouinard [ mochouinard ]
Hide
Permalink
Ken Rice added a comment -
Anthm, can you comment on this issue?
Show
Ken Rice added a comment - Anthm, can you comment on this issue?
Mike Jerris made changes -
Assignee Marc Olivier Chouinard [ mochouinard ] Mike Jerris [ mikej ]
Mike Jerris made changes -
Target Version 1.3.0 [ [10003] ]
Fix Version/s 1.3.0 [ 10003 ]
Ken Rice made changes -
Fix Version/s 1.2.9 [ 10412 ]
Fix Version/s 1.3.0 [ 10003 ]

People

  • Assignee:
    Mike Jerris
    Reporter:
    Seven Du
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: