ojab added a comment - 01/Aug/10 4:51 PM mod_conference fix

Git added a comment - 14/Dec/11 9:27 AM Repository: freeswitch Branch: refs/heads/master Commit: e566057 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=e566057 Closed By: mochouinard@moctel.com Comment: FS-2216 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Auto Admin added a comment - 27/Dec/11 8:17 PM Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin

Auto Admin added a comment - 27/Dec/11 8:17 PM Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Jeff Lenk added a comment - 27/Dec/11 10:02 PM Please add a comment as to why you reopened this bug - thanks

ojab added a comment - 28/Dec/11 1:51 AM There is still two cases of `if (sig);` in switch.c

ojab added a comment - 28/Dec/11 3:19 AM Complete patch, I'm able to build FS without modules using clang after applying.

Jeff Lenk added a comment - 28/Dec/11 8:59 AM thre seems to be several code modification here that dont belong such as: - if (bytes < 0) { - ret = (int) bytes; - goto end; - } would you clarify those?

ojab added a comment - 28/Dec/11 11:47 AM "bytes" is unsigned, so cannot be < 0 (like the other such deletions). clang has -Wtautological-compare switch for these case, which is enabled by default.

ojab added a comment - 28/Dec/11 12:40 PM and trivial fixes for all modules, enabled by default, except mod_sofia & mod_spandsp. Not sure about - if ((timeout_ms = atoi(argv[3])) < 0) { - timeout_ms = 0; - } + timeout_ms = atoi(argv[3]); in mod_dptools though

Anthony Minessale II added a comment - 28/Dec/11 12:52 PM if you have instances of unsigned getting assigned from output of atoi or being treated as signed, omitting it is not a solution. if you say unsigned int foo = atoi("-12"); it can still be casted to int and will hold the correct value. This is wrong but simple omissions like those suggested can lead to unexpected side effects. It would be preferable to convert the data to the proper type or fix it in a way that changes the least code or heavy regressing testing will be important. There is no atoi or atol type function that is portable that is exclusive to unsigned. Perhaps make one and add it to switch utils and use it in these cases. It would save a step of constantly verifying regular atoi calls.  

ojab added a comment - 29/Dec/11 4:11 AM Something like switch_atoi/switch_atol in clang2.patch? Not sure about: mod_conference.c: shouldn't be max_members_val == 0 incorrect? switch_core.c: ptime = 0 is invalid, isn't it? switch_rtp.c: looks like bytes < 0 is always false, can this check be removed?

ojab added a comment - 30/Dec/11 11:48 AM `if (argc >= 0)` check is always false, so it's deleted and contents reidented.

ojab added a comment - 07/Jan/12 3:58 PM Fix mod_httapi ("Format string is not a string literal" errors).

Git added a comment - 08/Jan/12 2:21 PM Repository: freeswitch Branch: refs/heads/master Commit: 2428883 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=2428883 Updated By: jeff@jefflenk.com Comment: FS-2216 partial with renaming FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Git added a comment - 08/Jan/12 2:21 PM Repository: freeswitch Branch: refs/heads/master Commit: 472ab0c http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=472ab0c Updated By: jeff@jefflenk.com Comment: FS-2216 partial FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Jeff Lenk added a comment - 08/Jan/12 2:23 PM I have not merged these yet mod_voicemail mod_spidermonkey_socket switch_rtp Those need further investigation or reasoning

Jeff Lenk added a comment - 09/Jan/12 10:13 AM I'm pretty sure the change to switch_rtp is ok too. The code path was alot simpler when that was added in 2008 and it looks to me that read_rtp_packet cant return anything less that zero.

ojab added a comment - 14/Jan/12 4:33 PM Updated patch (again FS 187abe0 req iframe on vid floor change), now also with mod_spandsp fix.

Jeff Lenk added a comment - 15/Jan/12 10:22 AM I dont understand what problem is being corrected by the change to mod_spandsp - also that code is not equivalent. Please expain why that code is a problem as that construct is used very commonly.

ojab added a comment - 15/Jan/12 10:43 AM The same uint = int issue: tx is unsigned, but tx_fax returns signed -> expression is always false. AFAIU tx is unused in goto done/end_unlock cases and tx_fax doesn't modify it's arguments, so assignment can be moved to else branch.

Jeff Lenk added a comment - 17/Jan/12 12:18 PM I cant identify where tx is defined as unsigned. see line 1389 int tx = 0; also line 73 spandsp\src\spandsp\fax.h SPAN_DECLARE_NONSTD(int) fax_tx(fax_state_t *s, int16_t *amp, int max_len); So I still dont see a problem with that code.

ojab added a comment - 17/Jan/12 1:36 PM AFAIU it is line 1686 in mod_spandsp_fax.c, which is     switch_size_t tx; which is something like typedef uintptr_t switch_size_t;

Git added a comment - 17/Jan/12 1:59 PM Repository: freeswitch Branch: refs/heads/master Commit: 6e83414 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=6e83414 Updated By: jeff@jefflenk.com Comment: FS-2216 clang change FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Git added a comment - 26/Jan/12 6:06 PM Repository: freeswitch Branch: refs/heads/master Commit: 049be82 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=049be82 Updated By: anthm@freeswitch.org Comment: FS-2216 found one bug that is 4 years old from commit 205cf0534f4c4c5a8ebccb2446a01ed0df100abb FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Git added a comment - 26/Jan/12 6:06 PM Repository: freeswitch Branch: refs/heads/master Commit: 812e5e9 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=812e5e9 Updated By: anthm@freeswitch.org Comment: FS-2216 FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

ojab added a comment - 27/Jan/12 7:39 AM New warning switch was added in llvm-trunk, so there is more errors https://llvm.org/viewvc/llvm-project?view=rev&sortby=rev&revision=148640 Patch in the attached file.

Anthony Minessale II added a comment - 27/Jan/12 9:53 AM That one seems kind of overzealous. What if someone injects some int value that is not in the enum?

ojab added a comment - 27/Jan/12 10:50 AM Then -Wswitch (which is default for clang, afaik) will warn you about switch over enum without default. So you'll have an error. Maybe -Wswitch should be added to CFLAGS to support clang<->gcc compatibility.

ojab added a comment - 03/Jul/12 1:31 AM Travis Cross has fixed most of the warnings in the meantime. I can build FS-git-3708c962 using version 3.2 (trunk 159643) with the only following change: diff --git a/src/fs_encode.c b/src/fs_encode.c index efd9373..7606138 100644 --- a/src/fs_encode.c +++ b/src/fs_encode.c @@ -66,7 +66,7 @@ int main(int argc, char *argv[])         switch_codec_t codec = { 0 };         char buf[2048];         switch_size_t len = sizeof(buf)/2; - switch_memory_pool_t *pool; + switch_memory_pool_t *pool = NULL;         int bitrate = 0;         int blocksize;

Git added a comment - 03/Jul/12 9:01 AM Repository: freeswitch Branch: refs/heads/master Commit: 305aa77 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=305aa77 Closed By: jeff@jefflenk.com Comment: FS-2216 --resolve clang FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

Auto Admin added a comment - 10/Sep/12 8:17 PM Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin

Auto Admin added a comment - 11/Sep/12 8:17 PM Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com