FreeSWITCH

BLF compliance with RFC-4235: dialog-info 'version=' field is reset to 0 on every new call instead of being incremented

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0.6, 1.0.7, 1.2.0, 1.3.0
  • Component/s: mod_sofia
  • Labels:
    None
  • Platform:
    Linux x86_64/gcc
  • Uname:
    Linux luna 2.6.30.10 #1 SMP PREEMPT Fri Feb 12 14:42:12 CET 2010 x86_64 GNU/Linux
  • CPU Info:
    Hide
    processor : 0
    vendor_id : AuthenticAMD
    cpu family : 15
    model : 107
    model name : AMD Athlon(tm) 64 X2 Dual Core Processor 4000+
    stepping : 1
    cpu MHz : 2109.160
    cache size : 512 KB
    physical id : 0
    siblings : 2
    core id : 0
    cpu cores : 2
    apicid : 0
    initial apicid : 0
    fpu : yes
    fpu_exception : yes
    cpuid level : 1
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good extd_apicid pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch
    bogomips : 4218.32
    TLB size : 1024 4K pages
    clflush size : 64
    cache_alignment : 64
    address sizes : 40 bits physical, 48 bits virtual
    power management: ts fid vid ttp tm stc 100mhzsteps

    processor : 1
    vendor_id : AuthenticAMD
    cpu family : 15
    model : 107
    model name : AMD Athlon(tm) 64 X2 Dual Core Processor 4000+
    stepping : 1
    cpu MHz : 2109.160
    cache size : 512 KB
    physical id : 0
    siblings : 2
    core id : 1
    cpu cores : 2
    apicid : 1
    initial apicid : 1
    fpu : yes
    fpu_exception : yes
    cpuid level : 1
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good extd_apicid pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch
    bogomips : 4218.88
    TLB size : 1024 4K pages
    clflush size : 64
    cache_alignment : 64
    address sizes : 40 bits physical, 48 bits virtual
    power management: ts fid vid ttp tm stc 100mhzsteps
    Show
    processor : 0 vendor_id : AuthenticAMD cpu family : 15 model : 107 model name : AMD Athlon(tm) 64 X2 Dual Core Processor 4000+ stepping : 1 cpu MHz : 2109.160 cache size : 512 KB physical id : 0 siblings : 2 core id : 0 cpu cores : 2 apicid : 0 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 1 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good extd_apicid pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch bogomips : 4218.32 TLB size : 1024 4K pages clflush size : 64 cache_alignment : 64 address sizes : 40 bits physical, 48 bits virtual power management: ts fid vid ttp tm stc 100mhzsteps processor : 1 vendor_id : AuthenticAMD cpu family : 15 model : 107 model name : AMD Athlon(tm) 64 X2 Dual Core Processor 4000+ stepping : 1 cpu MHz : 2109.160 cache size : 512 KB physical id : 0 siblings : 2 core id : 1 cpu cores : 2 apicid : 1 initial apicid : 1 fpu : yes fpu_exception : yes cpuid level : 1 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt rdtscp lm 3dnowext 3dnow rep_good extd_apicid pni cx16 lahf_lm cmp_legacy svm extapic cr8_legacy 3dnowprefetch bogomips : 4218.88 TLB size : 1024 4K pages clflush size : 64 cache_alignment : 64 address sizes : 40 bits physical, 48 bits virtual power management: ts fid vid ttp tm stc 100mhzsteps
  • FreeSWITCH GIT Revision:
    latest
  • Reproduced with GIT HEAD?:
    yes
  • Target Version:

Description

The version should keep on incrementing until a new SUBSCRIBE is received, otherwise they will get ignored by the device. See RFC4235 states that "Versions are scoped within a subscription.".

As a result, phones lights work well on the first call (version=0,1,2,...) and keep last known state on any subsequent call. Tested on Bria and Grandstream UAs.

An ugly workaround would be to keep version at "0", which works with those devices (but it should not work).

It's major for me because I cannot currently use BLF, but please lower the priority if you consider this a minor issue.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Minessale II added a comment -
indeed, the severity of the bug question is from our perspective not yours.
Show
Anthony Minessale II added a comment - indeed, the severity of the bug question is from our perspective not yours.
Hide
Permalink
François added a comment -
Sorry, next time i'll do better!

I tried to make a patch that saved the "version" in a new column of sip_subscriptions database but:
- I failed, i need a bit more C training and knowledge of FS code to make that type of patch.
- It's a matter of choice, maybe you guys don't want additional columns and sql queries just for dialog-info version and have a better solution.

Just wanted to share a possible option to resolve this issue.

Right now my workaround is a patch that puts version="0" in all dialog-infos. While it works with GS and Bria devices, it probably won't with more standard compliant devices that should ignore those packets.
Show
François added a comment - Sorry, next time i'll do better! I tried to make a patch that saved the "version" in a new column of sip_subscriptions database but: - I failed, i need a bit more C training and knowledge of FS code to make that type of patch. - It's a matter of choice, maybe you guys don't want additional columns and sql queries just for dialog-info version and have a better solution. Just wanted to share a possible option to resolve this issue. Right now my workaround is a patch that puts version="0" in all dialog-infos. While it works with GS and Bria devices, it probably won't with more standard compliant devices that should ignore those packets.
Hide
Permalink
Anthony Minessale II added a comment -
589502d


Show
Anthony Minessale II added a comment - 589502d

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    François
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: