FreeSWITCH

allow logging of uuids through mod_console and fs_cli

Details

  • Type: Improvement Improvement
  • Status: Reopened Reopened
  • Priority: Patch Patch
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.2.9
  • Component/s: mod_console, Scripts
  • Labels:
    None
  • Environment:
    Debian Lenny x64
  • Platform:
    Linux x86_64/gcc
  • FreeSWITCH GIT Revision:
    20c2740c641ead4f7bef8ba105d02ba3d8523745
  • Reproduced with GIT HEAD?:
    YES
  • Target Version:
    1.5

Description

mod_logfile and mod_syslog have uuid params which allow the logging of the uuid that generated a log message, if available.

mod_console and fs_cli do not have this feature, but it could be useful.

The attach patches add this feature. It is disabled by default, so that the default behaviour is unchanged. When the uuid param is set on mod_console, or the -U/--log-uuid command line argument given to fs_cli, the log message is prefixed by the uuid (the same behaviour as mod_logfile and mod_syslog).

fs_cli could be patched further so that the log-uuid setting is stored within profiles.
logger.pl also could be updated to show uuids (patch not supplied)
  1. Text File
    00-fs_cli-uuids.patch
    03/Nov/10 1:07 PM
    3 kB
    Steven Ayre
  2. Text File
    00-mod_console-uuids.patch
    03/Nov/10 1:07 PM
    2 kB
    Steven Ayre
  3. Text File
    03-fs_cli-uuids.patch
    05/Jan/11 11:33 AM
    3 kB
    Steven Ayre
  4. Text File
    04-fs_cli-uuids.patch
    15/Mar/12 7:22 AM
    4 kB
    Steven Ayre
  5. Text File
    05-fs_cli-uuids.patch
    21/Aug/12 3:16 AM
    4 kB
    Steven Ayre
  6. Text File
    06-fs_cli-uuids.patch
    21/Aug/12 3:18 AM
    4 kB
    Steven Ayre
  7. Text File
    07-fs_cli-uuids.patch
    14/May/13 6:40 AM
    4 kB
    Steven Ayre
  8. Text File
    fs_cli-uuids-2.patch
    03/Nov/10 3:25 PM
    3 kB
    Steven Ayre

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Steven Ayre added a comment -
v2 of the fs_cli patch
- fixes some compile problems with the previous patch
- adds support for setting log-uuid in the profile
Show
Steven Ayre added a comment - v2 of the fs_cli patch - fixes some compile problems with the previous patch - adds support for setting log-uuid in the profile
Steven Ayre made changes -
Field Original Value New Value
Attachment fs_cli-uuids-2.patch [ 13112 ]
Hide
Permalink
Steven Ayre added a comment -
Recent changes to fs_cli.c have broken to previous patches.

Attached is 03-fs_cli-uuids.patch which is updated for the latest trunk.
Show
Steven Ayre added a comment - Recent changes to fs_cli.c have broken to previous patches. Attached is 03-fs_cli-uuids.patch which is updated for the latest trunk.
Steven Ayre made changes -
Attachment 03-fs_cli-uuids.patch [ 13295 ]
Hide
Permalink
Marc Olivier Chouinard added a comment -
Please update, it wont apply anymore. I'll look at including it if it not already implemented.
Show
Marc Olivier Chouinard added a comment - Please update, it wont apply anymore. I'll look at including it if it not already implemented.
Hide
Permalink
Marc Olivier Chouinard added a comment -
3 Month no update.. reopen if you do
Show
Marc Olivier Chouinard added a comment - 3 Month no update.. reopen if you do
Marc Olivier Chouinard made changes -
Resolution Incomplete [ 4 ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Permalink
Steven Ayre added a comment -
00-mod_console-uuids.patch still applies against the latest git head.

Attached is 04-fs_cli-uuids.patch, updated for the latest git head (9bf2726e1b9e4996d8d10186b27081091e61bd9a Wed Mar 14 23:26:09 2012 -0500)
Show
Steven Ayre added a comment - 00-mod_console-uuids.patch still applies against the latest git head. Attached is 04-fs_cli-uuids.patch, updated for the latest git head (9bf2726e1b9e4996d8d10186b27081091e61bd9a Wed Mar 14 23:26:09 2012 -0500)
Steven Ayre made changes -
Attachment 04-fs_cli-uuids.patch [ 16110 ]
Hide
Permalink
Steven Ayre added a comment -
Reopened issue for the consideration of 00-mod_console-uuids.patch and 04-fs_cli-uuids.patch
Show
Steven Ayre added a comment - Reopened issue for the consideration of 00-mod_console-uuids.patch and 04-fs_cli-uuids.patch
Steven Ayre made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Incomplete [ 4 ]
Hide
Permalink
Steven Ayre added a comment -
I've just become aware today that this hasn't been applied to trunk yet. I know we're in feature freeze, but if I bring the patch up-to-date against the latest git head, would it get applied in time for 1.2 or would it be better to wait until after 1.2 is released?
Show
Steven Ayre added a comment - I've just become aware today that this hasn't been applied to trunk yet. I know we're in feature freeze, but if I bring the patch up-to-date against the latest git head, would it get applied in time for 1.2 or would it be better to wait until after 1.2 is released?
Hide
Permalink
Mike Jerris added a comment -
Now is a good time to update for review.
Show
Mike Jerris added a comment - Now is a good time to update for review.
Mike Jerris made changes -
Assignee Anthony Minessale II [ anthm ] Mike Jerris [ mikej ]
Hide
Permalink
Steven Ayre added a comment - - edited
I have updated these for the latest master 17faa239fed43ec76fe0ca03cb40aefab2356013 Tue Aug 21 00:39:56 2012 -0500

00-mod_console-uuids.patch still applies cleanly

05-fs_cli-uuids.patch is the updated patch (changes were needed due to the added batch mode option)
To avoid duplication of content in multiple printf() calls a line is logged with several printf calls - to print colour, uuid, event body then colour reset (colours omitted with -b). With the new batchmode option so many code paths were used otherwise that the code became less readable.
UUID logging is turned on with -U or --log-uuid. Reading the code although U: is currently listed in the getopt_long() option list I do not actually see it used anywhere, so it should be possible to use -U for UUIDs.

I'm currently building FS to confirm 05-fs_cli-uuids.patch works correctly and will update this ticket when confirmed.
Show
Steven Ayre added a comment - - edited I have updated these for the latest master 17faa239fed43ec76fe0ca03cb40aefab2356013 Tue Aug 21 00:39:56 2012 -0500 00-mod_console-uuids.patch still applies cleanly 05-fs_cli-uuids.patch is the updated patch (changes were needed due to the added batch mode option) To avoid duplication of content in multiple printf() calls a line is logged with several printf calls - to print colour, uuid, event body then colour reset (colours omitted with -b). With the new batchmode option so many code paths were used otherwise that the code became less readable. UUID logging is turned on with -U or --log-uuid. Reading the code although U: is currently listed in the getopt_long() option list I do not actually see it used anywhere, so it should be possible to use -U for UUIDs. I'm currently building FS to confirm 05-fs_cli-uuids.patch works correctly and will update this ticket when confirmed.
Hide
Permalink
Steven Ayre added a comment -
Added 05-fs_cli-uuids.patch
Show
Steven Ayre added a comment - Added 05-fs_cli-uuids.patch
Steven Ayre made changes -
Attachment 05-fs_cli-uuids.patch [ 16755 ]
Hide
Permalink
Steven Ayre added a comment -
06-fs_cli-uuids.patch is an updated cleanup.

The only difference from 05-fs_cli-uuids.patch is a minor whitespace correction.
Show
Steven Ayre added a comment - 06-fs_cli-uuids.patch is an updated cleanup. The only difference from 05-fs_cli-uuids.patch is a minor whitespace correction.
Steven Ayre made changes -
Attachment 06-fs_cli-uuids.patch [ 16756 ]
Hide
Permalink
Steven Ayre added a comment -
Confirmed working as expected.

To use add this to console.conf.xml:
    <param name="uuid" value="true"/>

And run fs_cli with -U
Show
Steven Ayre added a comment - Confirmed working as expected. To use add this to console.conf.xml:     <param name="uuid" value="true"/> And run fs_cli with -U
Mike Jerris made changes -
Target Version 1.3.0 [ [10003] ]
Fix Version/s 1.3.0 [ 10003 ]
Ken Rice made changes -
Fix Version/s 1.2.9 [ 10412 ]
Fix Version/s 1.3.0 [ 10003 ]
Hide
Permalink
Ken Rice added a comment -
Hey Steven, can you give a status on this ticket/patch one more time?

thanks
K
Show
Ken Rice added a comment - Hey Steven, can you give a status on this ticket/patch one more time? thanks K
Ken Rice made changes -
Assignee Mike Jerris [ mikej ] Ken Rice [ silik0n ]
Hide
Permalink
Ken Rice added a comment -
Ray thinks this might already be committed?
Show
Ken Rice added a comment - Ray thinks this might already be committed?
Hide
Permalink
Raymond Chandler added a comment -
if this isn't working as expected, please respond
Show
Raymond Chandler added a comment - if this isn't working as expected, please respond
Raymond Chandler made changes -
Status Reopened [ 4 ] Waiting for reporter [ 10000 ]
Hide
Permalink
Ken Rice added a comment -
closing due to inactivity.

Steven, if this is still an issue please re-open and update as required.
Show
Ken Rice added a comment - closing due to inactivity. Steven, if this is still an issue please re-open and update as required.
Ken Rice made changes -
Status Waiting for reporter [ 10000 ] Closed [ 6 ]
Hide
Permalink
Steven Ayre added a comment -
No, neither has been applied

mod_console:
   still unpatched in current head (4c81fdf3eec5c82a434a12e85b7f6cc1b6648318)
   no "uuid" param
   00-mod_console-uuids.patch still applies cleanly

fs_cli
   no "log-uuid" parameter
   patch no longer applies cleanly

I'll prepare a new update for fs_cli. In the meantime perhaps the mod_console can be applied?
Show
Steven Ayre added a comment - No, neither has been applied mod_console:    still unpatched in current head (4c81fdf3eec5c82a434a12e85b7f6cc1b6648318)    no "uuid" param    00-mod_console-uuids.patch still applies cleanly fs_cli    no "log-uuid" parameter    patch no longer applies cleanly I'll prepare a new update for fs_cli. In the meantime perhaps the mod_console can be applied?
Steven Ayre made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Target Version 1.3.0 [ [10003] ] 1.5 [ [10410] ]
Hide
Permalink
Steven Ayre added a comment -
Attached updated 07-fs_cli-uuids.patch

00-mod_console-uuids.patch still cleanly applies
Show
Steven Ayre added a comment - Attached updated 07-fs_cli-uuids.patch 00-mod_console-uuids.patch still cleanly applies
Steven Ayre made changes -
Attachment 07-fs_cli-uuids.patch [ 18541 ]

People

  • Assignee:
    Ken Rice
    Reporter:
    Steven Ayre
Vote (0)
Watch (4)

Dates

  • Created:
    Updated: