FreeSWITCH

Mod_khomp: building it requires some TLC

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.0.7
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    CentOS 5.5 x86_64
  • Platform:
    Linux x86_64/gcc
  • CPU Info:
    GenuineIntel - QEMU Virtual CPU version 0.13.0
  • GCC Version:
    4.1.2
  • FreeSWITCH GIT Revision:
    0e37dcb from Jan 23, 2011
  • Reproduced with GIT HEAD?:
    Yes

Description

There are a number of issues with building the mod_khomp module particularly related to its requirements: k3l

1) during the build process running tools/getk3l.sh and downloading k3l from the Internet is not allowed in any of the Enterprise and Government environments I know. I can disable the download and add the required file during the build. It would be even better if you just add the required file to mod_khomp/ and update it when necessary

2) the k3l_2.1_client_x86-64.sh script searches for a number of apps but gives strange results. Please note that the script is not run as root. Package builders in Enterprise and Government environments I know do not have root rights

install: depmod... *NOT FOUND* <-- depmod is present in /sbin
install: dialog... *NOT FOUND* <-- no idea what this is. is this maybe Ubuntu specific? I could not find a dialog app on CentOS
install: ldconfig... *NOT FOUND* <-- ldconfig is present in /sbin

3) packing k3l_2.1.0012_Client_x86_64tar.gz inside a shell script?
Why? Please don't do that or at least put on the wiki the information howto unpack it and extract k3l_2.1.0012_Client_x86_64tar.gz so that you can actually access the requirements. Why not put k3l_2.1.0012_Client_x86_64tar.gz and the shell script separately in the mod_khomp directory tree?

4) shell script refers to /usr/doc/khomp and /usr/src/khomp

The /usr/doc directory is wrong on RHEL/CentOS and I think also according to the LSB. Docs go into /usr/share/doc but this requires root rights... On RHEL/CentOS you need root rights to use /usr/src which builders in Enterprise and Government environments do not have.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
João Mesquita added a comment -
Sorry for my big delay on this issue. I was tangled with other things. I am assigning this to one of Khomp's developers.
Show
João Mesquita added a comment - Sorry for my big delay on this issue. I was tangled with other things. I am assigning this to one of Khomp's developers.
Hide
Permalink
Eduardo Nunes Pereira added a comment -
Oh, sorry by my big delay too, i will pass this assignment to our developer team
Show
Eduardo Nunes Pereira added a comment - Oh, sorry by my big delay too, i will pass this assignment to our developer team
Hide
Permalink
Eduardo Nunes Pereira added a comment -
1) It's really a fault the getk3l script try to install only, so we will put a option in getk3l.sh to download only then you can install in the costumer without necessary the downloads.
2) Must run as root, because our drivers must be compiled and installed
3) The content is inside the shell script just to automate the setup and the contents are binary only, so the content not need to be in tree.
4) We must study this
Show
Eduardo Nunes Pereira added a comment - 1) It's really a fault the getk3l script try to install only, so we will put a option in getk3l.sh to download only then you can install in the costumer without necessary the downloads. 2) Must run as root, because our drivers must be compiled and installed 3) The content is inside the shell script just to automate the setup and the contents are binary only, so the content not need to be in tree. 4) We must study this
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Patrick Laimbock added a comment -
Reopening. Will comment on the comments next.
Show
Patrick Laimbock added a comment - Reopening. Will comment on the comments next.
Hide
Permalink
Patrick Laimbock added a comment -
@Eduardo:

About your comment 1: I don't think we understood each other. There needs to be an option where *no* download takes place. This is needed for RPM/DEB build servers that do not have Internet access but where the file is already available (downloaded) and included in the source directory that the rpmbuild command uses to build the mod_khomp RPM or DEB.

About your comment 2: typically the build command on RPM/DEB build servers is *not* run as root. For security reasons it is not allowed (imagine running the getk3l script as root and the script has "rm -rf /" in it...). You are saying that the script "Must run as root". This seems like a bug. For building the drivers you should never require root rights. If your script requires root for building then it should be fixed. For installing the drivers during the RPM build process, all Makefiles should use the standard $DESTDIR variable (for example: make install DESTDIR=/var/tmp/lib/modules/2.6.18/kernel/drivers/...). Installing an RPM/DEB with the drivers does require root rights but this is different from installing the drivers during the RPM/DEB package building process.

This is all standard packaging stuff. If you are not familiar with it please check:
the Red Hat & Fedora Packaging Guidelines at http://fedoraproject.org/wiki/PackagingGuidelines
the kmodtool docs on the rpmfusion.org wiki at http://rpmfusion.org/Packaging/KernelModules/Kmods2

About your comment 3: the content is already in the tree because it's part of the shell script. So I don't understand your point. It makes sense to just split them and have the shell script and the binary tarballs in tree. For RPM/DEB package builders the current situation makes it challenging if not prohibitive. Look for example at Sangoma: they also make their x86 and x86_64 binary stuff available in separate tarballs. This makes it easy for packagers to pick the right one during the build process.

About your comment 4: just check the LSB or any Fedora or CentOS5/RHEL5 RPM. All documentation goes into /usr/share/doc
Show
Patrick Laimbock added a comment - @Eduardo: About your comment 1: I don't think we understood each other. There needs to be an option where *no* download takes place. This is needed for RPM/DEB build servers that do not have Internet access but where the file is already available (downloaded) and included in the source directory that the rpmbuild command uses to build the mod_khomp RPM or DEB. About your comment 2: typically the build command on RPM/DEB build servers is *not* run as root. For security reasons it is not allowed (imagine running the getk3l script as root and the script has "rm -rf /" in it...). You are saying that the script "Must run as root". This seems like a bug. For building the drivers you should never require root rights. If your script requires root for building then it should be fixed. For installing the drivers during the RPM build process, all Makefiles should use the standard $DESTDIR variable (for example: make install DESTDIR=/var/tmp/lib/modules/2.6.18/kernel/drivers/...). Installing an RPM/DEB with the drivers does require root rights but this is different from installing the drivers during the RPM/DEB package building process. This is all standard packaging stuff. If you are not familiar with it please check: the Red Hat & Fedora Packaging Guidelines at http://fedoraproject.org/wiki/PackagingGuidelines the kmodtool docs on the rpmfusion.org wiki at http://rpmfusion.org/Packaging/KernelModules/Kmods2 About your comment 3: the content is already in the tree because it's part of the shell script. So I don't understand your point. It makes sense to just split them and have the shell script and the binary tarballs in tree. For RPM/DEB package builders the current situation makes it challenging if not prohibitive. Look for example at Sangoma: they also make their x86 and x86_64 binary stuff available in separate tarballs. This makes it easy for packagers to pick the right one during the build process. About your comment 4: just check the LSB or any Fedora or CentOS5/RHEL5 RPM. All documentation goes into /usr/share/doc
Hide
Permalink
João Mesquita added a comment -
This won't be fixed because the company in question has a policy of not distributing their lib freely, not even as a binary, which is needed to compile mod_khomp.
Show
João Mesquita added a comment - This won't be fixed because the company in question has a policy of not distributing their lib freely, not even as a binary, which is needed to compile mod_khomp.

People

  • Assignee:
    Eduardo Nunes Pereira
    Reporter:
    Patrick Laimbock
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: