FreeSWITCH

PATCH: Add channel variable deny_refer_requests to make it possible to deny REFER requests

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Patch Patch
  • Resolution: Fixed
  • Affects Version/s: 1.0.7
  • Fix Version/s: 1.0.7
  • Component/s: mod_sofia
  • Labels:
    None
  • Environment:
    Windows 7, Visual Studio 2008
  • Platform:
    Vista/VS
  • FreeSWITCH GIT Revision:
    c18835d3f919c7ba260dfa0e61254fb305850518 2011-02-25 01:52:58
  • Reproduced with GIT HEAD?:
    Yes

Description

Sometimes it desirable to block an incoming REFER requests, on a per-call basis.

This patch reads variable "deny_refer_requests" from all (up to 4) legs involved in the REFER, if it's set to true it will deny the REFER request.

Please review and apply if you find it useful - get back to me if you want me to do modifications.

Thanks,

Peter
  1. Text File
    sofia.c-diff.txt
    27/May/11 11:04 AM
    3 kB
    Peter Olsson
  2. Text File
    sofia.c-diff.txt
    27/May/11 4:05 AM
    3 kB
    Peter Olsson
  3. Text File
    sofia.c-diff.txt
    25/Feb/11 3:58 AM
    3 kB
    Peter Olsson

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Olsson added a comment -
Updated patch to work for current git. Please review and get back to me with comments, or commit if everything seems ok :)

/Peter
Show
Peter Olsson added a comment - Updated patch to work for current git. Please review and get back to me with comments, or commit if everything seems ok :) /Peter
Hide
Permalink
Anthony Minessale II added a comment -
if (a_channel && (deny_refer_requests_var = switch_channel_get_variable(a_channel, "deny_refer_requests")) && switch_true(deny_refer_requests_var)) {
+ deny_refer_requests = 1;

you can improve this redundancy with something like this:

if (a_channel) {
     deny_refer_requests = switch_true(switch_channel_get_variable(a_channel, "deny_refer_requests"));
}

switch_true is NULL safe

Show
Anthony Minessale II added a comment - if (a_channel && (deny_refer_requests_var = switch_channel_get_variable(a_channel, "deny_refer_requests")) && switch_true(deny_refer_requests_var)) { + deny_refer_requests = 1; you can improve this redundancy with something like this: if (a_channel) {      deny_refer_requests = switch_true(switch_channel_get_variable(a_channel, "deny_refer_requests")); } switch_true is NULL safe
Hide
Permalink
Peter Olsson added a comment -
Thanks for the hint. I've optimized it a bit.
Show
Peter Olsson added a comment - Thanks for the hint. I've optimized it a bit.
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 9e12983 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=9e12983
Closed By: anthm@freeswitch.org

Comment:
FS-3100 --resolve
Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 9e12983 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=9e12983 Closed By: anthm@freeswitch.org Comment: FS-3100 --resolve
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Peter Olsson
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: