FreeSWITCH

add short duration digit detection to mod_spandsp inband DTMF detector

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.7
  • Fix Version/s: 1.0.7
  • Component/s: mod_spandsp
  • Labels:
    None
  • Platform:
    Linux x86/gcc
  • FreeSWITCH GIT Revision:
    head
  • Reproduced with GIT HEAD?:
    yes

Description

Updated mod_spandsp_dsp to feed frames to dtmf_rx in 10 ms chunks, to get more accurate and consistent DTMF duration measurement.

Added optional min_dup_digit_duration_ms channel variable to mod_spandsp_dsp.

This variable will detect a duplicate digit if the current digit is the same as the previous digit and the previous digit does not exceed the threshold defined by the variable.

For example:

min_dup_digit_duration_ms=30, DTMF 3 pressed twice

2011-08-16 14:41:54.938739 [DEBUG] mod_spandsp_dsp.c:58 DTMF BEGIN DETECTED: [3]
2011-08-16 14:41:54.958744 [DEBUG] mod_spandsp_dsp.c:70 DTMF END DETECTED: [3], duration = 20 ms
2011-08-16 14:41:54.998738 [DEBUG] mod_spandsp_dsp.c:66 DUP DTMF DETECTED: [3]
2011-08-16 14:41:55.118739 [DEBUG] mod_spandsp_dsp.c:70 DTMF END DETECTED: [3], duration = 180 ms
2011-08-16 14:41:55.258740 [DEBUG] mod_spandsp_dsp.c:58 DTMF BEGIN DETECTED: [3]
2011-08-16 14:41:55.358741 [DEBUG] mod_spandsp_dsp.c:70 DTMF END DETECTED: [3], duration = 110 ms

Issue Links

is related to

Improvement - An improvement or enhancement to an existing feature or task. FS-4109 Use dtmf duration reported from spandsp

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Minessale II added a comment -
coppice said this won't do any good since the detector already is set so feeding smaller pieces will not change anything.
also the 8k assumption is probably not the best approach.
Show
Anthony Minessale II added a comment - coppice said this won't do any good since the detector already is set so feeding smaller pieces will not change anything. also the 8k assumption is probably not the best approach.
Hide
Permalink
Christopher Rienzo added a comment -
I talked to coppice and confirmed that spandsp will not return DTMF duration, so my workaround is OK until that gets implemented.

Also, I verified that the spandsp DTMF detector assumes 8000 Hz sample rate, as mod_spandsp does.
Show
Christopher Rienzo added a comment - I talked to coppice and confirmed that spandsp will not return DTMF duration, so my workaround is OK until that gets implemented. Also, I verified that the spandsp DTMF detector assumes 8000 Hz sample rate, as mod_spandsp does.
Hide
Permalink
Christopher Rienzo added a comment -
Updated the patch- will only break up the frame into 10 ms chunks if the min_dup_digit_* variables are used.
Show
Christopher Rienzo added a comment - Updated the patch- will only break up the frame into 10 ms chunks if the min_dup_digit_* variables are used.
Hide
Permalink
Christopher Rienzo added a comment -
This change sucks... closing it.
Show
Christopher Rienzo added a comment - This change sucks... closing it.

People

  • Assignee:
    Christopher Rienzo
    Reporter:
    Christopher Rienzo
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: