FreeSWITCH

Allow grace time after 'endconf' member leaves the conference

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.7
  • Fix Version/s: 1.0.7
  • Component/s: mod_conference
  • Labels:
    None
  • Platform:
    Linux x86/gcc
  • FreeSWITCH GIT Revision:
    origin
  • Reproduced with GIT HEAD?:
    n/a
  • Target Version:

Description

Hi all,

I faced a problem with ending the conference when admin/moderator leaves. The request was not to end immediately after moderator disconnects, but rather allow other participants to continue over a specified amount of time. Playing with "sched_api" I finally decided that I need something more integrated with conference module.

The patch I present:
- defines two additions fields for extra time handling
- reads configuration parameter "endconf-grace-time" (integer) - number of seconds
- preserves current behavior if parameter is not defined (defaults to 0)
- if grace time is set, it will be printed out as an attribute while getting "xml_list"

Regards,

Mariusz

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Lenk added a comment -
what are you trying to accomplish that cannot be done by using the "hangup_after_conference" channel variable and returning to the dialplan to do the delay before hangup?
Show
Jeff Lenk added a comment - what are you trying to accomplish that cannot be done by using the "hangup_after_conference" channel variable and returning to the dialplan to do the delay before hangup?
Hide
Permalink
Mariusz Czułada added a comment -
In current state, if the last member with 'endconf' flag leaves the conference, it is terminated immediately, so IMHO no action in this member's dialplan can 'revive' the conference. Or course you can not set 'endconf' flag and try to enforce ending using some background task, but it makes 'enconf' flag unusable for this.

My suggestion was to allow some specified extra time for other participants to continue talking until the conference finally terminates without any additional code. Also, if a new 'enconf' users will join, current termination process will be abandoned; it will be started again if the last of them will leave.

Show
Mariusz Czułada added a comment - In current state, if the last member with 'endconf' flag leaves the conference, it is terminated immediately, so IMHO no action in this member's dialplan can 'revive' the conference. Or course you can not set 'endconf' flag and try to enforce ending using some background task, but it makes 'enconf' flag unusable for this. My suggestion was to allow some specified extra time for other participants to continue talking until the conference finally terminates without any additional code. Also, if a new 'enconf' users will join, current termination process will be abandoned; it will be started again if the last of them will leave.
Hide
Permalink
Jeff Lenk added a comment -
you didnt read my suggestion.
see http://wiki.freeswitch.org/wiki/Variable_hangup_after_conference
after control returns to the dialplan you can do whatever you want - play files, sleep then hangup etc.
Show
Jeff Lenk added a comment - you didnt read my suggestion. see http://wiki.freeswitch.org/wiki/Variable_hangup_after_conference after control returns to the dialplan you can do whatever you want - play files, sleep then hangup etc.
Hide
Permalink
Mariusz Czułada added a comment -
I did and I think it is not relevant. Here are two scenarios:

1 conference is created with wait-mod flag
2 normal users join; they hear MOH
3 user with moderator and endconf flags joins; conference starts
4 moderator disconnects; conference immediately ends

So moderator is required to stay till the end. If disconnection was accidental everyone will have to dial in again, recording session (if previously started) will be interrupted.

Now "my way":
1 same plus endconf_grace_time set to 300 seconds
2 same
3 Same
4 moderator disconnects; other participants can still talk for five more minutes

In this

Sent via PocketJIRA - www.pocketjira.com
Show
Mariusz Czułada added a comment - I did and I think it is not relevant. Here are two scenarios: 1 conference is created with wait-mod flag 2 normal users join; they hear MOH 3 user with moderator and endconf flags joins; conference starts 4 moderator disconnects; conference immediately ends So moderator is required to stay till the end. If disconnection was accidental everyone will have to dial in again, recording session (if previously started) will be interrupted. Now "my way": 1 same plus endconf_grace_time set to 300 seconds 2 same 3 Same 4 moderator disconnects; other participants can still talk for five more minutes In this Sent via PocketJIRA - www.pocketjira.com
Hide
Permalink
Anthony Minessale II added a comment -
if the mod calls back, does the conf resume and cancel the termination?

Sent via PocketJIRA - www.pocketjira.com
Show
Anthony Minessale II added a comment - if the mod calls back, does the conf resume and cancel the termination? Sent via PocketJIRA - www.pocketjira.com
Hide
Permalink
Mariusz Czułada added a comment -
Sorry, pressed wrong button on the phone ;)

In this case even when last user with 'endconf' flag hangs, other participants will still be able to talk in the conference.

So I think your suggestion is not helpful here. First, because after disconnection no other task could be performed. Second, because any action (even if executable) will be too late since conference is already over.

Regards,
Mariusz
Show
Mariusz Czułada added a comment - Sorry, pressed wrong button on the phone ;) In this case even when last user with 'endconf' flag hangs, other participants will still be able to talk in the conference. So I think your suggestion is not helpful here. First, because after disconnection no other task could be performed. Second, because any action (even if executable) will be too late since conference is already over. Regards, Mariusz
Hide
Permalink
Mariusz Czułada added a comment -
Yes, any new participant with 'endconf' cancels the countdown. So if mod parted accidentally, one should have enough time to rejoin while the rest still keep talking.
Show
Mariusz Czułada added a comment - Yes, any new participant with 'endconf' cancels the countdown. So if mod parted accidentally, one should have enough time to rejoin while the rest still keep talking.
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: fb43f80 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=fb43f80
Closed By: mochouinard@moctel.com

Comment:
FS-3705 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: fb43f80 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=fb43f80 Closed By: mochouinard@moctel.com Comment: FS-3705 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Mariusz Czułada
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: