FreeSWITCH

configure cleanup

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: AYFKM
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.2
  • Component/s: Configuration
  • Labels:
    None
  • Platform:
    FreeBSD/gcc
  • Uname:
    FreeBSD ports.freebsd.org 9.0-RELEASE FreeBSD
  • CPU Info:
    Hide
    CPU: Genuine Intel(R) CPU T2300 @ 1.66GHz (1663.11-MHz 686-class CPU)
      Origin = "GenuineIntel" Id = 0x6e8 Family = 6 Model = e Stepping = 8
      Features=0xfe1fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS>
      Features2=0x80000001<SSE3,HV>
      AMD Features=0x100000<NX>
      TSC: P-state invariant
    Show
    CPU: Genuine Intel(R) CPU T2300 @ 1.66GHz (1663.11-MHz 686-class CPU)   Origin = "GenuineIntel" Id = 0x6e8 Family = 6 Model = e Stepping = 8   Features=0xfe1fbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS>   Features2=0x80000001<SSE3,HV>   AMD Features=0x100000<NX>   TSC: P-state invariant
  • GCC Version:
    gcc version 4.2.1 20070831 patched [FreeBSD]
  • FreeSWITCH GIT Revision:
    HEAD
  • Reproduced with GIT HEAD?:
    Yes
  • Target Version:

Description

cleanup of a previous patch to make all the --with- options

also set --datadir=dbdir and --htmldir=htdocsdir

did some proper checking and setting.

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. FS-3895 Fix for configure.in

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Richard Neese added a comment -
here is the diff
Show
Richard Neese added a comment - here is the diff
Hide
Permalink
Jeff Lenk added a comment -
Im not sure why you closed the bug that mikej agreed to look at. When you do this you are just making it more difficult for people to keep track of what was happening.

In the future just reopen the existing bug.
Show
Jeff Lenk added a comment - Im not sure why you closed the bug that mikej agreed to look at. When you do this you are just making it more difficult for people to keep track of what was happening. In the future just reopen the existing bug.
Hide
Permalink
Ken Rice added a comment -
Richard, can you split this into 2 patches... one that does all the changes to configure.in minus the voicemail changes and one that does just the voicemail changes... that'll make it easier to evaluate everything

I have serious concerns with the voicemail changes as this will break backwards compatibility... however there is nothing that says we cant do that we just need to be able to properly evaluate just that change.
Show
Ken Rice added a comment - Richard, can you split this into 2 patches... one that does all the changes to configure.in minus the voicemail changes and one that does just the voicemail changes... that'll make it easier to evaluate everything I have serious concerns with the voicemail changes as this will break backwards compatibility... however there is nothing that says we cant do that we just need to be able to properly evaluate just that change.
Hide
Permalink
Richard Neese added a comment -
split for configure changess and vm changes
Show
Richard Neese added a comment - split for configure changess and vm changes
Hide
Permalink
Richard Neese added a comment -
update
Show
Richard Neese added a comment - update
Hide
Permalink
Richard Neese added a comment -
updated the patch and re diff
Show
Richard Neese added a comment - updated the patch and re diff
Hide
Permalink
Richard Neese added a comment -
here is the finished diff all fixed and tested as of today.
Show
Richard Neese added a comment - here is the finished diff all fixed and tested as of today.
Hide
Permalink
Richard Neese added a comment -
here is the rewrite
Show
Richard Neese added a comment - here is the rewrite
Hide
Permalink
Richard Neese added a comment -
new diff for freeswitch freebsd configure changes
Show
Richard Neese added a comment - new diff for freeswitch freebsd configure changes
Hide
Permalink
Jeff Lenk added a comment -
Richard please delete the unneeded patches here to make it easier to determine what is relevant.
Show
Jeff Lenk added a comment - Richard please delete the unneeded patches here to make it easier to determine what is relevant.
Hide
Permalink
Richard Neese added a comment -
rm 2 pieces specific call recovery that are not specific to the issue the patch covers
Show
Richard Neese added a comment - rm 2 pieces specific call recovery that are not specific to the issue the patch covers
Hide
Permalink
Richard Neese added a comment -
posting all my patch files in a new jira
Show
Richard Neese added a comment - posting all my patch files in a new jira

People

  • Assignee:
    Ken Rice
    Reporter:
    Richard Neese
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: