FreeSWITCH

don't list all registrations when doing sofia xmlstatus profile foo & show a registrations counter

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.7
  • Fix Version/s: 1.0.7
  • Component/s: mod_sofia
  • Labels:
    None
  • Environment:
    n/a
  • Platform:
    Linux x86_64/gcc
  • FreeSWITCH GIT Revision:
    fbe4e6475d7c873e8adbd770c1c2b86f02c3da85
  • Reproduced with GIT HEAD?:
    yes

Description

A while ago I submitted a patch for not listing registrations when doing "sofia status profile foo" because that list can become quite long.

http://jira.freeswitch.org/browse/FS-3699

Since a while I've been using the "sofia xmlstatus profile foo" to get statistics to graph them in Cacti, so now I'm experiencing the same problem there, a long list of registrations, while all I want to get is some basic statistics. Documentation in the wiki already shows that reg should be appended with xmlstatus if you want to list them:

http://wiki.freeswitch.org/wiki/Mod_sofia#View_SIP_Registrations

Attached patch disables listing of all the registrations when doing xmlstatus without the reg appended.

The patch also adds a field "registrations" to both status and xmlstatus with a counter value.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Anthony Minessale II added a comment -
I see at least 1 switch_mprintf in there with no free can you audit it for leaks?
Show
Anthony Minessale II added a comment - I see at least 1 switch_mprintf in there with no free can you audit it for leaks?
Hide
Permalink
Leon de Rooij added a comment -
I made a mistake there, sorry ! fixed it in 2nd patch.

Valgrind doesn't show any leaks anymore where I made the changes.
Show
Leon de Rooij added a comment - I made a mistake there, sorry ! fixed it in 2nd patch. Valgrind doesn't show any leaks anymore where I made the changes.
Leon de Rooij made changes -
Field Original Value New Value
Attachment mod_sofia_xmlstatus_not_list_registrations_and_status_and_xmlstatus_show_reg_count_noleak.patch.txt [ 15923 ]
Attachment vg.log [ 15922 ]
Hide
Permalink
Leon de Rooij added a comment -
Do you think it would be alright to make these changes ?

removing the overhead of listing all the registrations all the time would be really useful here. A single sofia xmlstatus on an active profile is 2.5MB right now, querying a few times every minute generates more load than the calls themselves - see attached graphs where I disabled doing the xmlstatus for a while today :)
Show
Leon de Rooij added a comment - Do you think it would be alright to make these changes ? removing the overhead of listing all the registrations all the time would be really useful here. A single sofia xmlstatus on an active profile is 2.5MB right now, querying a few times every minute generates more load than the calls themselves - see attached graphs where I disabled doing the xmlstatus for a while today :)
Hide
Permalink
Anthony Minessale II added a comment -
sure we can add that.
P.S. anything that relies on constant polling is a bad idea in an event driven environment ;)
Show
Anthony Minessale II added a comment - sure we can add that. P.S. anything that relies on constant polling is a bad idea in an event driven environment ;)
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 926af03 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=926af03
Closed By: anthm@freeswitch.org

Comment:
FS-3940 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 926af03 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=926af03 Closed By: anthm@freeswitch.org Comment: FS-3940 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Git made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
Hide
Permalink
Leon de Rooij added a comment -
Computer says "thanks" ! :-)
Show
Leon de Rooij added a comment - Computer says "thanks" ! :-)
Leon de Rooij made changes -
Attachment wlsfs2_cpu_usage_after_patch.png [ 15963 ]
Attachment wlsfs2_load_average_after_patch.png [ 15964 ]
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Auto Admin made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Leon de Rooij
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:

Time Tracking

Estimated:
10m
Original Estimate - 10 minutes
Remaining:
10m
Remaining Estimate - 10 minutes
Logged:
Not Specified
Time Spent - Not Specified