Details
-
Type:
New Feature
-
Status:
Waiting for reporter
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: None
-
Fix Version/s: None
-
Component/s: mod_skinny
-
Labels:None
-
Environment:Ubuntu 11.10
-
Platform:Linux x86_64/gcc
-
FreeSWITCH GIT Revision:git-fcab3de 2012-03-15
-
Reproduced with GIT HEAD?:yes
Description
I have some patches for mod_skinny I would like to submit that will allow the Cisco 7985 video phone to register.
The function skinny_handle_request in skinny_server.c had to be altered in how it detects if a device is already registered as a 7985 will send a KeepAliveMessage before a Register (this was verified from the chan_sccp code).
In addition, several new skinny message routines had to be written to handled the requests from the 7985:
Station -> Callmanager
UpdateCapabilitiesMessage (0x0030)
ServerReqMessage (0x0012)
Callmanager -> Station
ServerResMessage (0x009E)
The current patch will only handle audio but video might come in the future.
The function skinny_handle_request in skinny_server.c had to be altered in how it detects if a device is already registered as a 7985 will send a KeepAliveMessage before a Register (this was verified from the chan_sccp code).
In addition, several new skinny message routines had to be written to handled the requests from the 7985:
Station -> Callmanager
UpdateCapabilitiesMessage (0x0030)
ServerReqMessage (0x0012)
Callmanager -> Station
ServerResMessage (0x009E)
The current patch will only handle audio but video might come in the future.
Activity
Nathan Neulinger
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Mathieu Parent [ sathieu ] | Nathan Neulinger [ nneul ] |
| Status | Open [ 1 ] | Waiting for reporter [ 10000 ] |
Please separate your patch in several:
- skinny_codecs as enum
- updatecapabilities handling
- serverrequest handling
- Cisco IP Phone 7985 (two-lines patch)
- ...
Also:
- remove the patch about SKINNY_MEGA_DEBUG (ifndef), this is for development only
- use current code conventions (for example, replace "DEVICE_UPDATECAPABILITIES 0x0030" with "UPDATE_CAPABILITIES_MESSAGE 0x0030", update struct members customPictureFormatWidth -> custom_picture_format_width, remove lel_ prefixes)
Make sure your patch is licensed under Mozilla Public License 1.1.