FreeSWITCH

implement switch_speex_fmtp_parse

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0.7
  • Fix Version/s: 1.2.0
  • Component/s: mod_speex
  • Labels:
    None
  • Environment:
    CentOS 5.4 x86_64
  • Platform:
    Linux x86/gcc
  • FreeSWITCH GIT Revision:
    888bf8132df5c17d
  • Reproduced with GIT HEAD?:
    yes

Description

The attached patch updates switch_speex_fmtp_parse to set the encoder quality based on the mode specified in the fmtp= line. VBR is also enabled/disabled based on the fmtp= line. Note: the cng setting is ignored since I don't know how to enable/disable that on speex. See RFC 5574.

Also removed the SWITCH_CODEC_SILENCE* stuff that is ignored by the core.


Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 4817768 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=4817768
Closed By: anthm@freeswitch.org

Comment:
FS-4037 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 4817768 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=4817768 Closed By: anthm@freeswitch.org Comment: FS-4037 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: febb9cc http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=febb9cc
Updated By: anthm@freeswitch.org

Comment:
FS-4037 revert 48177682991e54201674364223603abb3ebefa9b causing audio issues with speex


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: febb9cc http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=febb9cc Updated By: anthm@freeswitch.org Comment: FS-4037 revert 48177682991e54201674364223603abb3ebefa9b causing audio issues with speex FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Anthony Minessale II added a comment -
seems to cause audio issues on the conference
Show
Anthony Minessale II added a comment - seems to cause audio issues on the conference
Hide
Permalink
Christopher Rienzo added a comment -
Attached the fix. Root cause was that the default settings were not applied if the fmtp was NULL.
Show
Christopher Rienzo added a comment - Attached the fix. Root cause was that the default settings were not applied if the fmtp was NULL.
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 9ced4a3 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=9ced4a3
Closed By: anthm@freeswitch.org

Comment:
FS-4037 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 9ced4a3 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=9ced4a3 Closed By: anthm@freeswitch.org Comment: FS-4037 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Christopher Rienzo
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: