FreeSWITCH

Cancel reason header not passed to other leg

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: mod_sofia
  • Labels:
    None
  • Environment:
    W2K8
  • Platform:
    Win32_64/VS
  • Uname:
    NA
  • CPU Info:
    NA
  • GCC Version:
    NA
  • FreeSWITCH GIT Revision:
    175b6b223a63873e19b5a3df7c9ac144189046fa
  • Reproduced with GIT HEAD?:
    Yes
  • FSS Support Agreement Customer Number and Company name:
    Hide
    Hi,

    See attached patch for sending the CANCEL REASON header to all forked calls.
    Previously, it only sent to one target.

    I verified it on latest git.

    Thanks,
    Ron
    Show
    Hi, See attached patch for sending the CANCEL REASON header to all forked calls. Previously, it only sent to one target. I verified it on latest git. Thanks, Ron

Description

Hi,

FreesSwitch does not pass the sip cancel REASON header to other leg.

The scenario:

An external user A calls a registered user B. Before user B answers the call, a cancel request is sent to FreeSwitch with a standard reason header (07:03:51.610742):

   Reason: SIP;cause=200;text="Call completed elsewhere";ms-acceptedby="sip:test1@lynctest.org"
   
However, FreeSwitch sends a cancel request to user B with wrong reason header (07:03:52.030680):

   Reason: FreeSWITCH;cause=487;text="ORIGINATOR_CANCEL"

   
The reason header is important to phone, because this header affects the missed call indication.

Note - configuration is default out of the box, except for defining a user and a simple dialplan to route calls.

See attached log and capture.

Thanks,
Ron
  1. Text File
    0001-Pass-cancel-reason-for-forked-call.patch
    13/Feb/13 3:02 AM
    2 kB
    Ron Avriel
  2. Text File
    0001-typo-for-FS-4053.patch
    16/Apr/12 12:48 AM
    1 kB
    Ron Avriel
  3. Text File
    0003-Fix-for-sending-peer-SIP-CANCEL-REASON-header-to-all.patch
    17/May/12 2:32 AM
    2 kB
    Ron Avriel
  4. Text File
    freeswitch.log
    29/Mar/12 2:40 AM
    123 kB
    Ron Avriel
  5. File
    wrong-cancel.pcap
    29/Mar/12 2:40 AM
    6 kB
    Ron Avriel

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. FS-4294 after 183 session progress, a later 603 decline error is not passed through

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 221b82f http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=221b82f
Updated By: anthm@freeswitch.org

Comment:
FS-4053 try this


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 221b82f http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=221b82f Updated By: anthm@freeswitch.org Comment: FS-4053 try this FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Ron Avriel added a comment -
Thanks for quick response.

Sorry, but same results after fix.

The problem is in switch_channel_set_variable_partner_var_check() added to sofia.c:

if ((uuid = switch_channel_get_variable(channel, SWITCH_SIGNAL_BOND_VARIABLE))) {

returns null.

Thanks,
Ron
Show
Ron Avriel added a comment - Thanks for quick response. Sorry, but same results after fix. The problem is in switch_channel_set_variable_partner_var_check() added to sofia.c: if ((uuid = switch_channel_get_variable(channel, SWITCH_SIGNAL_BOND_VARIABLE))) { returns null. Thanks, Ron
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 8618e22 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=8618e22
Updated By: anthm@freeswitch.org

Comment:
FS-4053 try this


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 8618e22 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=8618e22 Updated By: anthm@freeswitch.org Comment: FS-4053 try this FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Ken Rice added a comment -
Ron, any further comments on this?
Show
Ken Rice added a comment - Ron, any further comments on this?
Hide
Permalink
Ron Avriel added a comment -
Hi,

See my patch from today. I confirm that your fix together with my patch solves the issue and you can close it.

Thanks,
Ron
Show
Ron Avriel added a comment - Hi, See my patch from today. I confirm that your fix together with my patch solves the issue and you can close it. Thanks, Ron
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 6e512f1 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=6e512f1
Closed By: anthm@freeswitch.org

Comment:
FS-4053 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 6e512f1 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=6e512f1 Closed By: anthm@freeswitch.org Comment: FS-4053 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Jeff Lenk added a comment -
Ron it seems that your last comment here is sorta hidden, what else is needed here?
Show
Jeff Lenk added a comment - Ron it seems that your last comment here is sorta hidden, what else is needed here?
Hide
Permalink
Ron Avriel added a comment -
Jeff,

Originally, I opened this bug because FS did not pass cancel reason to other leg.
This bug was fixed and closed, but then I found out that if the call is forked then the cancel reason is not sent to all.
I submitted the patch "0003-Fix-for-sending-peer-SIP-CANCEL-REASON-header-to-all.patch" that solves this new problem
and reopened the bug.

So please verify and add this patch.

Thanks,
Ron

Show
Ron Avriel added a comment - Jeff, Originally, I opened this bug because FS did not pass cancel reason to other leg. This bug was fixed and closed, but then I found out that if the call is forked then the cancel reason is not sent to all. I submitted the patch "0003-Fix-for-sending-peer-SIP-CANCEL-REASON-header-to-all.patch" that solves this new problem and reopened the bug. So please verify and add this patch. Thanks, Ron
Hide
Permalink
Ken Rice added a comment -
Hey guys was this ever resolved with the final patch? if not is it still a problem in the latest git master head?
Show
Ken Rice added a comment - Hey guys was this ever resolved with the final patch? if not is it still a problem in the latest git master head?
Hide
Permalink
Ron Avriel added a comment -
See my patch from today. It's based on previous patch (that was never merged) and applies to latest version.

Ron
Show
Ron Avriel added a comment - See my patch from today. It's based on previous patch (that was never merged) and applies to latest version. Ron

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Ron Avriel
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: