FreeSWITCH

add array_shift vs array_pop to amf0

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: 1.2.9
  • Component/s: freeswitch-core
  • Labels:
    None
  • Platform:
    Linux x86/gcc
  • FreeSWITCH GIT Revision:
    d2edcad66ec367ad3c48ed6a08dc3abdf8d71ee3
  • Reproduced with GIT HEAD?:
    YES
  • Target Version:

Description

add array_shift to use the array as a fifo

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Seven Du added a comment -
sorry I didn't find mod_rtmp entry when I create this issue.
Show
Seven Du added a comment - sorry I didn't find mod_rtmp entry when I create this issue.
Hide
Permalink
Anthony Minessale II added a comment -
Are you making some local mods to mod_rtmp that require this?
Show
Anthony Minessale II added a comment - Are you making some local mods to mod_rtmp that require this?
Hide
Permalink
Seven Du added a comment -
Maybe not "required" but my friend made some changes and used this as a fifo queue. He had changed the _pop function actually and I added this for him.

My be use switch_queue_push/pop is the more right way but I assume it might be ok to just add a new feature?

We are at the early stage to add video support and use it to re-assemble h264 NALUs add the code is a pain (as we talked in email list for white spaces) before I can convince him to use git.


Show
Seven Du added a comment - Maybe not "required" but my friend made some changes and used this as a fifo queue. He had changed the _pop function actually and I added this for him. My be use switch_queue_push/pop is the more right way but I assume it might be ok to just add a new feature? We are at the early stage to add video support and use it to re-assemble h264 NALUs add the code is a pain (as we talked in email list for white spaces) before I can convince him to use git.
Hide
Permalink
Raymond Chandler added a comment -
we need to see if this is still needed and makes sense
Show
Raymond Chandler added a comment - we need to see if this is still needed and makes sense
Hide
Permalink
William King added a comment -
Seven, if you can confirm that this is still needed I'll run it through a few tests and get it pushed in.
Show
William King added a comment - Seven, if you can confirm that this is still needed I'll run it through a few tests and get it pushed in.
Hide
Permalink
Seven Du added a comment -
This is not needed by the time. I can reopen later if we need this.

Thanks.
Show
Seven Du added a comment - This is not needed by the time. I can reopen later if we need this. Thanks.

People

  • Assignee:
    William King
    Reporter:
    Seven Du
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: