FreeSWITCH

SpanDSP ignores the value of timezone channel variable

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: mod_spandsp
  • Labels:
    None
  • Platform:
    Linux x86/gcc
  • CPU Info:
    Hide
    processor : 0
    vendor_id : GenuineIntel
    cpu family : 15
    model : 4
    model name : Intel(R) Xeon(TM) CPU 3.60GHz
    stepping : 3
    cpu MHz : 3599.575
    cache size : 2048 KB
    physical id : 0
    siblings : 2
    core id : 0
    cpu cores : 1
    apicid : 0
    initial apicid : 0
    fpu : yes
    fpu_exception : yes
    cpuid level : 5
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr
    bogomips : 7199.15
    clflush size : 64
    cache_alignment : 128
    address sizes : 36 bits physical, 48 bits virtual
    power management:

    processor : 1
    vendor_id : GenuineIntel
    cpu family : 15
    model : 4
    model name : Intel(R) Xeon(TM) CPU 3.60GHz
    stepping : 3
    cpu MHz : 3599.575
    cache size : 2048 KB
    physical id : 3
    siblings : 2
    core id : 0
    cpu cores : 1
    apicid : 6
    initial apicid : 6
    fpu : yes
    fpu_exception : yes
    cpuid level : 5
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr
    bogomips : 7200.77
    clflush size : 64
    cache_alignment : 128
    address sizes : 36 bits physical, 48 bits virtual
    power management:

    processor : 2
    vendor_id : GenuineIntel
    cpu family : 15
    model : 4
    model name : Intel(R) Xeon(TM) CPU 3.60GHz
    stepping : 3
    cpu MHz : 3599.575
    cache size : 2048 KB
    physical id : 0
    siblings : 2
    core id : 0
    cpu cores : 1
    apicid : 1
    initial apicid : 1
    fpu : yes
    fpu_exception : yes
    cpuid level : 5
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr
    bogomips : 7200.79
    clflush size : 64
    cache_alignment : 128
    address sizes : 36 bits physical, 48 bits virtual
    power management:

    processor : 3
    vendor_id : GenuineIntel
    cpu family : 15
    model : 4
    model name : Intel(R) Xeon(TM) CPU 3.60GHz
    stepping : 3
    cpu MHz : 3599.575
    cache size : 2048 KB
    physical id : 3
    siblings : 2
    core id : 0
    cpu cores : 1
    apicid : 7
    initial apicid : 7
    fpu : yes
    fpu_exception : yes
    cpuid level : 5
    wp : yes
    flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr
    bogomips : 7200.77
    clflush size : 64
    cache_alignment : 128
    address sizes : 36 bits physical, 48 bits virtual
    power management:
    Show
    processor : 0 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Xeon(TM) CPU 3.60GHz stepping : 3 cpu MHz : 3599.575 cache size : 2048 KB physical id : 0 siblings : 2 core id : 0 cpu cores : 1 apicid : 0 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr bogomips : 7199.15 clflush size : 64 cache_alignment : 128 address sizes : 36 bits physical, 48 bits virtual power management: processor : 1 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Xeon(TM) CPU 3.60GHz stepping : 3 cpu MHz : 3599.575 cache size : 2048 KB physical id : 3 siblings : 2 core id : 0 cpu cores : 1 apicid : 6 initial apicid : 6 fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr bogomips : 7200.77 clflush size : 64 cache_alignment : 128 address sizes : 36 bits physical, 48 bits virtual power management: processor : 2 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Xeon(TM) CPU 3.60GHz stepping : 3 cpu MHz : 3599.575 cache size : 2048 KB physical id : 0 siblings : 2 core id : 0 cpu cores : 1 apicid : 1 initial apicid : 1 fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr bogomips : 7200.79 clflush size : 64 cache_alignment : 128 address sizes : 36 bits physical, 48 bits virtual power management: processor : 3 vendor_id : GenuineIntel cpu family : 15 model : 4 model name : Intel(R) Xeon(TM) CPU 3.60GHz stepping : 3 cpu MHz : 3599.575 cache size : 2048 KB physical id : 3 siblings : 2 core id : 0 cpu cores : 1 apicid : 7 initial apicid : 7 fpu : yes fpu_exception : yes cpuid level : 5 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall lm constant_tsc pebs bts pni dtes64 monitor ds_cpl est tm2 cid cx16 xtpr bogomips : 7200.77 clflush size : 64 cache_alignment : 128 address sizes : 36 bits physical, 48 bits virtual power management:
  • FreeSWITCH GIT Revision:
    4e4b4444d26c424263d520fe33cfa2686762bb3f
  • Reproduced with GIT HEAD?:
    Yes

Description

My server's time is set to UTC, regardless of the value of fax_timezone, spandsp puts the UTC time on the header of the fax

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Steve Underwood added a comment -
The variable "fax_timezone" controls the timezone on a FAX by FAX basis, so you can have different time zones for different users, similar to the way voice mail is handled. If "fax_timezone" is not set you will get the local time zone.
Show
Steve Underwood added a comment - The variable "fax_timezone" controls the timezone on a FAX by FAX basis, so you can have different time zones for different users, similar to the way voice mail is handled. If "fax_timezone" is not set you will get the local time zone.
Hide
Permalink
Mohammad Navid added a comment - - edited
I just made another test on my dev machines current setup:

machine 1 (sender), timezone: PST
machine 2(receiver), timezone: PST

When I don't set the variable fax_timezone and send the fax, on the header i get the PST time
originate sofia/carrier/14082151211@192.168.1.11 &txfax(/tmp/fax.tiff)

When i set the variable fax_timezone to any of the standard timezones, I get UTC time on the header
originate [fax_timezone=Europe/Amsterdam]sofia/carrier/14082151211@192.168.1.11 &txfax(/tmp/fax.tiff)

however, if I set Amsterdam's timezone's as "CET-1CEST,M3.5.0,M10.5.0/3" the header gets the correct time, but it does not work for all timezones for instance if I set EEST (for Africa/Cairo) it puts the UTC time
Show
Mohammad Navid added a comment - - edited I just made another test on my dev machines current setup: machine 1 (sender), timezone: PST machine 2(receiver), timezone: PST When I don't set the variable fax_timezone and send the fax, on the header i get the PST time originate sofia/carrier/14082151211@192.168.1.11 &txfax(/tmp/fax.tiff) When i set the variable fax_timezone to any of the standard timezones, I get UTC time on the header originate [fax_timezone=Europe/Amsterdam]sofia/carrier/14082151211@192.168.1.11 &txfax(/tmp/fax.tiff) however, if I set Amsterdam's timezone's as "CET-1CEST,M3.5.0,M10.5.0/3" the header gets the correct time, but it does not work for all timezones for instance if I set EEST (for Africa/Cairo) it puts the UTC time
Hide
Permalink
Steve Underwood added a comment -
When did "Europe/Amsterdam" become a time zone descriptor? If you put garbage like that as the fax_timezone it defaults to UTC.
Show
Steve Underwood added a comment - When did "Europe/Amsterdam" become a time zone descriptor? If you put garbage like that as the fax_timezone it defaults to UTC.
Hide
Permalink
Steve Underwood added a comment -
Ah, I see the confusion. Other parts of Freeswitch translate strings like "Europe/Amsterdam" into POSIX format timezone descriptors. I didn't realise that before. The variable that goes to spandsp for the FAX timezones is pushed straight through to spandsp without such interpretation. That shouldn't be hard to improve.

The Freeswitch configuration file contains "EEST" for Cairo, but surely that is wrong. A timezone string should have at least one number. "EEST-2" works OK, and I think -2 is the correct offset for Cairo.
Show
Steve Underwood added a comment - Ah, I see the confusion. Other parts of Freeswitch translate strings like "Europe/Amsterdam" into POSIX format timezone descriptors. I didn't realise that before. The variable that goes to spandsp for the FAX timezones is pushed straight through to spandsp without such interpretation. That shouldn't be hard to improve. The Freeswitch configuration file contains "EEST" for Cairo, but surely that is wrong. A timezone string should have at least one number. "EEST-2" works OK, and I think -2 is the correct offset for Cairo.
Hide
Permalink
Mohammad Navid added a comment -
Thank you very much for the reply, there was no documentation about fax_timezone on wiki, I found it through looking at the mod_spandsp, I didn't look at timezone.c in lib spandsp my assumption was it's something similar to this http://wiki.freeswitch.org/wiki/Variable_timezone
Show
Mohammad Navid added a comment - Thank you very much for the reply, there was no documentation about fax_timezone on wiki, I found it through looking at the mod_spandsp, I didn't look at timezone.c in lib spandsp my assumption was it's something similar to this http://wiki.freeswitch.org/wiki/Variable_timezone
Hide
Permalink
Steve Underwood added a comment -
I found something which says the right POSIX timezone string for Cairo should be EET-2EEST,M4.5.5/01:00,M9.5.5/03:00 . Someone needs to verify that.
Show
Steve Underwood added a comment - I found something which says the right POSIX timezone string for Cairo should be EET-2EEST,M4.5.5/01:00,M9.5.5/03:00 . Someone needs to verify that.
Hide
Permalink
Steve Underwood added a comment -
I committed changes to the timezone infor for Cairo, and to make "fax_timezone" be resolved from names like Asia/HongKong or from a POSIX string. See how that goes.
Show
Steve Underwood added a comment - I committed changes to the timezone infor for Cairo, and to make "fax_timezone" be resolved from names like Asia/HongKong or from a POSIX string. See how that goes.
Hide
Permalink
Mike Jerris added a comment -
Mohammad- can you please confirm if this patch helps?
Show
Mike Jerris added a comment - Mohammad- can you please confirm if this patch helps?
Hide
Permalink
Mohammad Navid added a comment - - edited
Its working very well, thank you very much Steve.

One quick question which is a bit unrelated to this report, in the timezone.xml isn't Los Angeles supposed to be PST8PDT,M3.2.0/2,M11.1.0/2 instead of PST8PDT,M3.2.0,M11.1.0 ?

Regarding Cairo, i'm not sure how reliable timeanddate.com is but it says last times they had day light saving was 2010 http://www.timeanddate.com/worldclock/timezone.html?n=53
Show
Mohammad Navid added a comment - - edited Its working very well, thank you very much Steve. One quick question which is a bit unrelated to this report, in the timezone.xml isn't Los Angeles supposed to be PST8PDT,M3.2.0/2,M11.1.0/2 instead of PST8PDT,M3.2.0,M11.1.0 ? Regarding Cairo, i'm not sure how reliable timeanddate.com is but it says last times they had day light saving was 2010 http://www.timeanddate.com/worldclock/timezone.html?n=53
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

People

  • Assignee:
    Steve Underwood
    Reporter:
    Mohammad Navid
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: