FreeSWITCH

Database corruption handling

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: freeswitch-core
  • Labels:
    None
  • Environment:
    W2K8
  • Platform:
    Win32_64/VS
  • Uname:
    NA
  • CPU Info:
    NA
  • GCC Version:
    NA
  • FreeSWITCH GIT Revision:
    992e05667cbf72251504d93625f0c01ef20ac792
  • Reproduced with GIT HEAD?:
    Yes

Description

Hi,

I encountered SQLite database corruption several times. In that case, DB queries work but any modification fails with an error "database disk image is malformed".

This is a deadlock situation, because FS continues to run, but fails in almost every operation. Even a FS restart doesn't solve the problem.

The attached patch uses SQLite integrity_check on startup to detect this corruption, and if corrupted it deletes the DB file and recreates a new empty DB.

Thanks,
Ron

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ken Rice added a comment -
Ron, cna you freshen this patch up and make sure it still applies cleanly?
Show
Ken Rice added a comment - Ron, cna you freshen this patch up and make sure it still applies cleanly?
Hide
Permalink
Ron Avriel added a comment -
Ken,

Wasn't this ever merged?

Ron
Show
Ron Avriel added a comment - Ken, Wasn't this ever merged? Ron
Hide
Permalink
Jeff Lenk added a comment -
Ron it seems to still apply. but was never merged can you verify it still applies as intended?
Show
Jeff Lenk added a comment - Ron it seems to still apply. but was never merged can you verify it still applies as intended?
Hide
Permalink
Ron Avriel added a comment -
I verified patch still applies on latest version.

Ron
Show
Ron Avriel added a comment - I verified patch still applies on latest version. Ron
Hide
Permalink
Ken Rice added a comment -
Hey Tony what do you think of this patch? I can commit if you are ok
Show
Ken Rice added a comment - Hey Tony what do you think of this patch? I can commit if you are ok
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: f8d769a http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=f8d769a
Closed By: SwK

Comment:
FS-4289 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: f8d769a http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=f8d769a Closed By: SwK Comment: FS-4289 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Ken Rice added a comment -
commited f8d769ae1ce86c814cca03cbc8dee659447d3a19

slight change to patch, using strcasecmp instead of stricmp
will not affect functionality as they are functionally the same, depends on where you are coming from for which to use
Show
Ken Rice added a comment - commited f8d769ae1ce86c814cca03cbc8dee659447d3a19 slight change to patch, using strcasecmp instead of stricmp will not affect functionality as they are functionally the same, depends on where you are coming from for which to use
Hide
Permalink
Antonio Silva added a comment - - edited
Hi,

Could we have some option to enable or disable this feature? The error log is very nice to have it, but we should be able to choose to delete or not the database.

Is quite a drastic measure just delete the database if is corrupted, i know that if the database is corrupted there nothing much to do... but sometimes miracle happen... and the corruption level is not that critical.
We could do a dump of the database an recover some data or even all the data... if is delete you just loose everything (like it happen to me when i saw the error message... :( ).

I was using lua scripts and dbh, so it could be optional for this case ....

Thanks,

António
Show
Antonio Silva added a comment - - edited Hi, Could we have some option to enable or disable this feature? The error log is very nice to have it, but we should be able to choose to delete or not the database. Is quite a drastic measure just delete the database if is corrupted, i know that if the database is corrupted there nothing much to do... but sometimes miracle happen... and the corruption level is not that critical. We could do a dump of the database an recover some data or even all the data... if is delete you just loose everything (like it happen to me when i saw the error message... :( ). I was using lua scripts and dbh, so it could be optional for this case .... Thanks, António
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 1b8ef18 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=1b8ef18
Updated By: anthm@freeswitch.org

Comment:
FS-4289 changed to backup the file with epoch time instead of delete it


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 1b8ef18 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=1b8ef18 Updated By: anthm@freeswitch.org Comment: FS-4289 changed to backup the file with epoch time instead of delete it FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Anthony Minessale II added a comment -
Patch caused bug FS-5141 this patch is too agressive and causes db issues.
Show
Anthony Minessale II added a comment - Patch caused bug FS-5141 this patch is too agressive and causes db issues.

People

  • Assignee:
    Ken Rice
    Reporter:
    Ron Avriel
Vote (0)
Watch (6)

Dates

  • Created:
    Updated: