FreeSWITCH

[patch] Fix after implementing setting enable-use-system-time

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2.0
  • Fix Version/s: 1.2.0
  • Component/s: freeswitch-core
  • Labels:
    None
  • Environment:
    Windows 7, Visual Studio 2010
  • Platform:
    Win32_64/VS
  • CPU Info:
    N/A
  • FreeSWITCH GIT Revision:
    b1ae97466d95ff68abdf8b84216dcecbdb3cbcc8
  • Reproduced with GIT HEAD?:
    Yes

Description

This patch fixes a few glitches introduced in commit b1ae974.

 - switch_time_ref() should return monotonic clock reference when SYSTEM_TIME is not enabled

 - runtime.offset should be calculated using monotonic reference in switch_time_sync(), when SYSTEM_TIME is not enabled.

 - When looping to check if the monotonic clock is working, the monotonic reference should be used if not setting SYSTEM_TIME has been set (changed to switch_time_ref) - Maybe always the monotonic reference should be used (-1) if MONO is enabled, since that what's this check are really for anyway.

I think these changes should make everything work as before.

While wring this I realized yet another thing - I will post the patch soon :)

/Peter

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. FS-4390 regression from commit b1ae97466d95ff68abdf8b84216dcecbdb3cbcc8

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Peter Olsson added a comment - - edited
Ok, here is the final patch.

I also added an update to runtime.mono_initiated, if the monotonic clock in Windows is enabled, since that will initialize too late.

I think now that we should maybe make the monotonic clock in Windows default as well. Do you think that's a good idea? I'll fix a patch if it sounds ok for you.

If Windows user want to go the old way, they can just use your new param instead.

/Peter
Show
Peter Olsson added a comment - - edited Ok, here is the final patch. I also added an update to runtime.mono_initiated, if the monotonic clock in Windows is enabled, since that will initialize too late. I think now that we should maybe make the monotonic clock in Windows default as well. Do you think that's a good idea? I'll fix a patch if it sounds ok for you. If Windows user want to go the old way, they can just use your new param instead. /Peter
Hide
Permalink
Jay Binks added a comment -
 this patch fixes regression FS-4390 in linux..
Show
Jay Binks added a comment -  this patch fixes regression FS-4390 in linux..
Hide
Permalink
Git added a comment -
Repository: freeswitch
Branch: refs/heads/master
Commit: 939a267 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=939a267
Closed By: jeff@jefflenk.com

Comment:
FS-4387 --resolve


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Git added a comment - Repository: freeswitch Branch: refs/heads/master Commit: 939a267 http://fisheye.freeswitch.org/changelog/freeswitch.git/?cs=939a267 Closed By: jeff@jefflenk.com Comment: FS-4387 --resolve FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com
Hide
Permalink
Auto Admin added a comment -
Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours.
If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue.

Thanks,
  Jira Admin
Show
Auto Admin added a comment - Due to a long period of inactivity (13 or more days), this issue is due to be automatically close within 24 hours. If this issue is not actually resolved, please reopen it and add appropriate comments to help developers fix the issue. Thanks,   Jira Admin
Hide
Permalink
Auto Admin added a comment -
Since there has been no change to the status of this issue, it is being closed for inactivity

Thanks,
  Jira Admin


FreeSWITCH Support Contracts and Consulting Services available!

Contact us:
Email: consulting@freeswitch.org
Web: http://www.freeswitch.org
Phone: +1-918-420-9266
Tollfree: +1-877-742-2583
Fax: +1-918-420-9267
iNum: +883 5100 1420 9266


Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony!
http://www.cluecon.com

Show
Auto Admin added a comment - Since there has been no change to the status of this issue, it is being closed for inactivity Thanks,   Jira Admin FreeSWITCH Support Contracts and Consulting Services available! Contact us: Email: consulting@freeswitch.org Web: http://www.freeswitch.org Phone: +1-918-420-9266 Tollfree: +1-877-742-2583 Fax: +1-918-420-9267 iNum: +883 5100 1420 9266 Come To ClueCon in August to learn more about FreeSWITCH and Internet Telephony! http://www.cluecon.com

People

  • Assignee:
    Anthony Minessale II
    Reporter:
    Peter Olsson
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: