FreeSWITCH

Install on OS X shows wrong FreeSwitch version

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.1
  • Component/s: Build System
  • Labels:
    None
  • Environment:
    iMac OS X 10.6.8
  • Platform:
    OS/X/gcc
  • CPU Info:
    Core 2 Duo
  • FreeSWITCH GIT Revision:
    FreeSWITCH Version 1.2.0-rc2 (1.2.0-rc2) <- Probably wrong
  • Reproduced with GIT HEAD?:
    Yes

Description

This may be minor but I thought someone should know that for the last few weeks, including a fresh rebuild from scratch today which I thought would show 1.2.1 (8/15 11am pacific), the version command shows "FreeSWITCH Version 1.2.0-rc2 (1.2.0-rc2)". If someone needed to open a Jira it might be a good idea to fix this since I could not find a way to display the actual git version.

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. FS-4436 version is incorrectly shown

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeff Lenk added a comment -
are you using master(head) or the 1.2 branch?
Show
Jeff Lenk added a comment - are you using master(head) or the 1.2 branch?
Hide
Permalink
Mario G added a comment -
I did: git clone git://git.freeswitch.org/freeswitch.git to install from scratch while trying to solve a several months old problem. I had done this three times in the last month and all had the exact same version, even after several git pulls. The last git pull even showed 1.2.1 but no change to the version after make current.
Show
Mario G added a comment - I did: git clone git://git.freeswitch.org/freeswitch.git to install from scratch while trying to solve a several months old problem. I had done this three times in the last month and all had the exact same version, even after several git pulls. The last git pull even showed 1.2.1 but no change to the version after make current.
Hide
Permalink
Peter Olsson added a comment -
I've noticed this as well. It seems that the build system for Mac doesn't correctly build/run the print_git_revision command, which is used to create the git revision stuff.

I'm not very good at Mac though, I just use it for fun mostly. But I'll try to have a look when I get back home.

/Peter
Show
Peter Olsson added a comment - I've noticed this as well. It seems that the build system for Mac doesn't correctly build/run the print_git_revision command, which is used to create the git revision stuff. I'm not very good at Mac though, I just use it for fun mostly. But I'll try to have a look when I get back home. /Peter
Hide
Permalink
Peter Olsson added a comment -
It seems that OSX doesn't support \W. I changed the regex, and now it seems to work properly. Please commit this patch.

/Peter
Show
Peter Olsson added a comment - It seems that OSX doesn't support \W. I changed the regex, and now it seems to work properly. Please commit this patch. /Peter
Hide
Permalink
Jeff Lenk added a comment -
Travis,

Would you review this?

Thanks
Show
Jeff Lenk added a comment - Travis, Would you review this? Thanks
Hide
Permalink
Travis Cross added a comment -
Thanks Mario for your report, Peter for your comments, and Jeff for letting me know about this issue.

I believe this bug to result from the same dependency issues (or lack thereof) that cause FS-4436, so I'm marking this as a duplicate.
Show
Travis Cross added a comment - Thanks Mario for your report, Peter for your comments, and Jeff for letting me know about this issue. I believe this bug to result from the same dependency issues (or lack thereof) that cause FS-4436 , so I'm marking this as a duplicate.
Hide
Permalink
Peter Olsson added a comment -
Travis. For Mac OS X it's another issue as well - the regex is incompatible with non gnu versions of sed (so the git revision is never put into place). Please look into the attached patch, which should solve the main issue for OSX, and should be compatible with everything else.

/Peter
Show
Peter Olsson added a comment - Travis. For Mac OS X it's another issue as well - the regex is incompatible with non gnu versions of sed (so the git revision is never put into place). Please look into the attached patch, which should solve the main issue for OSX, and should be compatible with everything else. /Peter
Hide
Permalink
Travis Cross added a comment -
Thanks Peter; applied at ebd3f4944c69eaa62d40eac278c835d51a144199.
Show
Travis Cross added a comment - Thanks Peter; applied at ebd3f4944c69eaa62d40eac278c835d51a144199.
Hide
Permalink
Mario G added a comment -
Thanks gang! The version command now shows:
FreeSWITCH Version 1.3.0+git~20120822T150820Z~e008af0e50 (1.3.0; git at commit e008af0e50 on Wed, 22 Aug 2012 15:08:20 Z)
Show
Mario G added a comment - Thanks gang! The version command now shows: FreeSWITCH Version 1.3.0+git~20120822T150820Z~e008af0e50 (1.3.0; git at commit e008af0e50 on Wed, 22 Aug 2012 15:08:20 Z)

People

  • Assignee:
    Travis Cross
    Reporter:
    Mario G
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: